ember-fastboot / ember-fastboot/ember-cli-fastboot

discuss file system checking in FastBoot.require

Open
#812 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
850
Forks
161
Avg merge
17h 45m
Merged PRs (30d)
19

Description

Every time `FastBoot.require` is run, `execSync` is run no matter how many times you call it [here](https://github.com/ember-fastboot/fastboot/blob/b62e795c8c21c4a5dca09f2cf20e4367c843fc7b/src/ember-app.js#L101).
Can this be optimized away? Perhaps maintain a string list of the packages already looked up, and skip the file system if found.
I would like to avoid people having to worry about caching the result of this in user land.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.