ember-fastboot / ember-fastboot/ember-cli-fastboot

We can't use dummy app for tests

Open
#719 0 comments 0 reactions 0 assignees View on GitHub
test
Dominant language
JavaScript
Stars
850
Forks
161
Avg merge
17h 45m
Merged PRs (30d)
19

Description

```
TypeError: Cannot read property 'outputPath' of undefined
at app.use (/Users/davidlaird/projects/ember-cli-fastboot/index.js:313:42)
```
The `ember-cli-fastboot` addon needs to come before `broccoli-serve-files` to SSR files.

Running the dummy app will result in the following error

```
TypeError: Cannot read property 'outputPath' of undefined
at app.use (/Users/davidlaird/projects/ember-cli-fastboot/index.js:313:42)
```

https://github.com/ember-fastboot/ember-cli-fastboot/blob/master/index.js#L325

The list of addons (truncated) when running the dummy app.
```
[ 'testem-url-rewriter',
'ember-cli-fastboot',
'tests-server-middleware',
'history-support-middleware',
'live-reload-middleware',
'broccoli-watcher',
'broccoli-serve-files',
'proxy-server-middleware',
...
'ember-cli-babel' ]
```

This an app list of addons (truncated) with Fastboot SSR it's files.
```
[ 'amd-transform',
'tests-server-middleware',
'history-support-middleware',
'live-reload-middleware',
'broccoli-watcher',
'ember-cli-fastboot',
'broccoli-serve-files',
'proxy-server-middleware',
...
'ember-source',
'ember-welcome-page',
'qunit-dom' ]
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.