ember-fastboot / ember-fastboot/ember-cli-fastboot

Some tests break under npm5

Open
#547 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
850
Forks
161
Avg merge
17h 45m
Merged PRs (30d)
19

Description

The `module-whitelist` test fixture injects two unpublished node modules directly into the node_modules directory before calling `npm install`. This is tolerated by npm 4. But it's an error in npm 5.

```
npm ERR! code E404
npm ERR! 404 Not Found: fake-addon@*
```

This problem is compounded by the fact that ember-cli-addon-tests [swallows exceptions](https://github.com/tomdale/ember-cli-addon-tests/issues/163) inside its app.run method, so you won't notice right away that npm is failing, and you get errors later in the test when modules are not found.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.