ember-cli / ember-cli/eslint-plugin-ember

Bug: require-computed-property-dependencies incorrectly flags a key w/ nesting after brace expansion

Open
#782 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

### What
```javascript
Ember.computed('article.{comments,title}.innerProperty', function() {
return this.article.title.innerProperty + someFunction(this.article.comments.innerProperty);
});
```
throws from `require-computed-property-dependencies`.

the auto-fixer will expand the keys, which causes `use-brace-expansion` to throw:
```javascript
Ember.computed('article.comments.innerProperty', 'article.title.innerProperty', function () {
return this.article.title.innerProperty + someFunction(this.article.comments.innerProperty);
}),
```

Not sure whether one or both rules should be adjusted here, or maybe the auto-fixer.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.