ember-cli / ember-cli/eslint-plugin-ember
order-in-components: bad fixing
- Dominant language
- JavaScript
- Stars
- 263
- Forks
- 214
- Avg merge
- 30m
- Merged PRs (30d)
- 5
Description
Hi,
I've found some code where running `eslint --fix` using `order-in-components` rule produce bad code.
Input
```js
import Ember from 'ember';
const {
Component,
inject: {
service
}
} = Ember;
export default Component.extend({
currentUser: service(),
logoUrl: `${CDN_URL }/static/img/concord-small.png`,
videoUrl: null // data down
});
````
output
```js
import Ember from 'ember';
const {
Component,
inject: {
service
}
} = Ember;
export default Component.extend({
currentUser: service(),
videoUrl: null logoUrl: `${CDN_URL }/static/img/concord-small.png`,
// data down
});
```
here is my configuration rule:
```
'ember/order-in-components': [2, {
order: [
'service',
'property',
'unknown',
'single-line-function',
'multi-line-function',
'observer',
'init',
'didReceiveAttrs',
'willRender',
'willInsertElement',
'didInsertElement',
'didRender',
'didUpdateAttrs',
'willUpdate',
'didUpdate',
'willDestroyElement',
'willClearRender',
'didDestroyElement',
'empty-method',
'method',
'actions',
]
}],
```
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.