ember-cli / ember-cli/eslint-plugin-ember

Incorrectly identifies components

Open
#235 5 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

I'm not aware of how `eslint-plugin-ember` works internally, but I think it needs to be more intelligent in terms of how it determines _what_ it is linting (specifically with regards to the `order-in-` rules).

For example:

I have a **Route** here: `lib/styleguide/app/routes/styleguide/common/components/tag-editor.js`

But, this addon determines it as **Component**, as you can see in the screenshot.
(It says "Should be above `setupController`, _but components don't have `setupController`_!)

screen shot 2018-03-11 at 19 59 45

If I rename the directory above "components" to something else, then all works as expected.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.