ember-cli / ember-cli/eslint-plugin-ember

Outdated recommendation in ember/no-runloop rule: Suggests ember-lifeline despite lack of recent updates

Open
#2,185 3 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

The ESLint rule ember/no-runloop currently recommends using ember-lifeline, ember-concurrency, or @ember/destroyable as alternatives to the deprecated @ember/runloop functions like later. However, ember-lifeline has not been updated in over a year, and this package may no longer be the best recommendation for new Ember projects.

Steps to reproduce:
1. Update to Ember 5.12
2. Run ESLint with the ember/no-runloop rule enabled
3. Observe that the error message recommends using ember-lifeline
4. Current Behavior: The rule suggests using ember-lifeline, which is an outdated package that hasn't been updated for over a year.

```javascript
[lint:js] 32:31 error Don't use @ember/runloop functions. Use ember-lifeline, ember-concurrency, or @ember/destroyable instead. For this case, you can replace later with runTask from ember-lifeline ember/no-runloop
[lint:js] 86:7 error Don't use @ember/runloop functions. Use ember-lifeline, ember-concurrency, or @ember/destroyable instead ember/no-runloop
```

Expected Behavior: The rule should recommend using more up-to-date alternatives, such as:
1. ember-concurrency?
2. Other?

Rule: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-runloop.md
Discussion on Discord: https://discord.com/channels/480462759797063690/480501885837770763/1294265500569960510

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.