ember-cli / ember-cli/eslint-plugin-ember

`ember/no-ember-testing-in-module-scope` catches assigning `Ember.testing = ...` too

Open
#1,453 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

Not sure how important this really is. The `ember/no-ember-testing-in-module-scope` rule (the docs, the error message, etc) claims to be about reading the value and stashing it somewhere (i.e. `let testing = Ember.testing;`), but in practice it is also catching assigning to it (`Ember.testing = false`).

I agree most of the time you shouldn't do that anyway, and in the internals where that is needed it's probably fine to disable the rule, but never the less, it seems like the rule is not doing what we expected it to do, not sure if that's intentional or not?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.