ember-cli / ember-cli/eslint-plugin-ember

[V2 Addons] Lint against importing test-support

Open
#1,437 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

I'm not sure if linting is the right place to do this, but we have a pretty good standard now on the phrase "test-support", so, in a v2 addon, that would live at:
```
src/
test-support.js
```

and it would not be included in any bundle if not imported (which is great!)
however, I think we could run in to problems if folks accidentally do `import Foo from 'my-addon/test-support'` in app code -- in that the test-support files, qunit-dom, etc would then become part of the app bundle, which we don't want.

ref: https://github.com/embroider-build/embroider/issues/268

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.