ember-cli / ember-cli/eslint-plugin-ember

New Rule: Requiring hbs`` literals

Open
#1,337 0 comments 0 reactions 0 assignees View on GitHub
enhancement New Rule
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

It's possible to use ```hbs(`foo`)```, but this usage style is frowned upon by Embroider (https://github.com/embroider-build/embroider/blob/031ce6d8a3137f5df6106be26c336b92ed948717/packages/core/src/babel-plugin-inline-hbs.ts#L212)
It'd be nice to have a lint rule to catch it.

### Bad:
```js
import { render } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';

render(hbs(`test`)); // has wrapping parens, breaking the hbs template literal
```

### Fixed version:
```js
import { render } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';

render(hbs`test`);
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.