ember-cli / ember-cli/eslint-plugin-ember

False positive for `no-unused-services` when component is passed to function expressions

Open
#1,258 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
263
Forks
214
Avg merge
30m
Merged PRs (30d)
5

Description

Ember 3.24
ESlint v7.31
eslint-plugin-ember v10.5.1

While evaluating this rule on apps at work, I discovered it triggered in the following scenario:

```js
import Component from '@glimmer/component';
import { inject as service } from '@ember/service';

const SomeUtilityFn = (component) => component.someService.someMethod();

export default class MyComponent extends Component {
@service someService;

get foo() {
return SomeUtilityFn(this);
}
}
```

Given that the helper method is defined in this file (vs imported), I didn't expect the rule to be triggered.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.