ember-cli / ember-cli/ember-try

Stop using `--no-lockfile` / `--no-shrinkwrap` by default? 🤔

Open
#597 3 comments 7 reactions 0 assignees View on GitHub
question
Dominant language
JavaScript
Stars
180
Forks
57
PR merge metrics
No merged PRs in 30d

Description

I think it is about time that we considered removing the `--no-lockfile`/`--no-shrinkwrap` defaults for `yarn` and `npm` scenarios.

As of #409, it is _possible_ to avoid if you'd like (that hook allows you to customize the options explicitly, with no default values) but the default of "ignoring lockfile" seems a bit wrong to me nowadays. I'd like to see us be able to have most scenarios use the lockfile and just bump the specific dependencies in the scenario. In my opinion that much more closely resembles what folks will **actually** do in practice.

For example, I would like to have `ember-cli` use `ember-try` scenarios for its floating dependencies test and have that scenario look like:

```js
{
name: 'floating-dependencies',
npmOptions: ['--no-lockfile'],
}
```

Thoughts?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.