ember-cli / ember-cli/ember-try

pnpm duplicates lead to errors

Open
#1,108 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
180
Forks
57
PR merge metrics
No merged PRs in 30d

Description

We have a library addon, that uses `getApplication()` from `@ember/test-helpers` as part of its test-support. Tests are working fine. Used ember version is `6.3`. Now renovate attempts an update of `@ember/test-helpers` package from v3 -> v5. This fails on ember-try with other ember versions, because `getApplication()` returns `undefined`. After a debugging session, I figured the reason for this:

Image

Duplicate of test-helpers for the ember-5.12 scenario. Apparently both are used, one stores the application in module scope, the other is asked to return it.

It's not necessarily a problom of ember-try, but the context in which this is appearing. So I am wondering if there are some clever people, that already figured out a solution.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.