ember-cli / ember-cli/ember-page-title

`loading` subroute in conjunction with equilevel `index` route produce incorrect entries in the browser history

Open
#282 1 comment 2 reactions 0 assignees View on GitHub
bug
Dominant language
JavaScript
Stars
187
Forks
58
PR merge metrics
No merged PRs in 30d

Description

Checkout this routes structure:
Screenshot 2024-01-22 at 17 32 28

When I navigate from the root app route down to Project down to Store, then back up to Project and finally find myself on the app route again, I would expect this full path reflected in the browser history. However, this is what I see there:

Screenshot 2024-01-22 at 17 35 03

Here's how the picture starts looking different (and correct) when I delete the `loading.hbs` subroute highlighted green in the first screenshot:
Screenshot 2024-01-22 at 17 37 39

I can also confirm that deleting the `index` subroute (without touching the `loading` one) also produces the correct history:
Screenshot 2024-01-22 at 17 43 39

So to conclude, having both `index` and `loading` subroutes make the framework generate incorrect entries in the browser history while removing either of them makes things look correct. [Here's](https://github.com/azhiv/ember-page-title-repro) the reproduction repo.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.