ember-cli / ember-cli/ember-page-title

Improvements to getPageTitle test-support helper

Open
#212 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
187
Forks
58
PR merge metrics
No merged PRs in 30d

Description

We probably should add comment block so IDEs could give hints of expected parameters OR provide TypeScript interface file. I think proper JSDoc for starters would be nice.

This helper does have some internal logic comments in it, we should probably remove it or separate it still for testing specifically this addon vs public helper.

The `Array.pop()` workaround for consumers is not needed, it's only applicable for tests in this repository.

_Originally posted by @raido in https://github.com/ember-cli/ember-page-title/issues/209#issuecomment-763450848_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.