ember-cli / ember-cli/ember-fetch

Rename import path to `ember-fetch`

Open
#330 11 comments 7 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
176
Forks
78
PR merge metrics
No merged PRs in 30d

Description

It's a best practice in general, for imports to come from their package name rather than some more "convenient" name, and will become more so [as Embroider lands](https://github.com/emberjs/rfcs/blob/embroider/text/0000-embroider-v2-package-format.md#renaming-rules):

> New addons *should not* use renaming rules because it's confusing when the imports people type don't align with their real dependencies.

The import style here should simply be:

```js
import fetch from 'ember-fetch';
```

This is not a blocker for use with Embroider, as there are solutions to support the existing flow, but is a nice improvement and will eliminate one thing that has to be done for this to use Embroider. It also has the nice upside of eliminating *all* shenanigans required to have this do the right thing for TypeScript integration!

This would be a breaking change, but should also be trivially codemod-able.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.