ember-cli / ember-cli/ember-cli-inject-live-reload

Bug: new Ember app doesn't transition into or out-of broccoli-middleware error page

Open
#187 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
23
Forks
49
PR merge metrics
No merged PRs in 30d

Description

### Expected behaviour

1. I have a working build, the page reloads when I make a change
2. I introduce a breaking change (eg. template compile error), the page reloads to show the error page with a error description and stack trace (broccoli-middleware)
3. I fix the breaking change, resulting in a successful rebuild, the page reloads to show the application again

### Current behaviour

The below GIF shows a newly generated ember app not reloading to show the ember error page and, once the build error is fixed, not reloading to return to the application.

![2022-03-03 15-34-56 2022-03-03 15_41_48](https://user-images.githubusercontent.com/7144173/156603328-77a868b1-7d40-4291-9a6e-12b196b30310.gif)

I'm not 100% certain but this feels like a regression, I thought ember apps always transitioned into and out-of the broccoli error page by default.

### System info
```
live-reload-repro main* @ws ⫸ ember --version
ember-cli: 3.28.5
node: 14.15.0
os: linux x64
```

```
live-reload-repro main* @ws ⫸ yarn why ember-cli-inject-live-reload
yarn why v1.22.10
[1/4] Why do we have the module "ember-cli-inject-live-reload"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "ember-cli-inject-live-reload@2.1.0"
info Has been hoisted to "ember-cli-inject-live-reload"
info This module exists because it's specified in "devDependencies".
info Disk size without dependencies: "440KB"
info Disk size with unique dependencies: "812KB"
info Disk size with transitive dependencies: "2.12MB"
info Number of shared dependencies: 11
Done in 1.09s.
```

[Reproduction in an app](https://github.com/22a/ember-live-reload-repro), but it's just `ember new --yarn` on ember-cli@3.28.5

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.