ember-cli / ember-cli/ember-cli-inject-live-reload

Add CLI flag for --live-reload-js-url

Open
#150 4 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
23
Forks
49
PR merge metrics
No merged PRs in 30d

Description

The config value `liveReloadJsUrl` can be set via `.ember-cli` but not as a command-line flag (`--live-reload-js-url`).

This is different from the four config values that can be set using either the config file or CLI flags (see photo).

***

*FOR REFERENCE (photo from repo readme: https://github.com/ember-cli/ember-cli-inject-live-reload)*

![image](https://user-images.githubusercontent.com/122287/92592214-85fe9f80-f29f-11ea-8a41-51727e0f1599.png)

*END REFERENCE*

***

Would you be open to making liveReloadJsUrl configurable via a CLI flag? If so, is there any place in addition to the following file that needs to be modified?

https://github.com/ember-cli/ember-cli/blob/073c32eff73c58eee62d6327b50f4422f0cd01cc/lib/commands/serve.js#L62

cc @rwjblue @kellyselden happy to hear your thoughts about this

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.