ember-cli / ember-cli/ember-cli-htmlbars

Runtime error on import { hbs } from 'ember-cli-htmlbars' in storybook

Open
#524 14 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
77
Forks
65
PR merge metrics
No merged PRs in 30d

Description

Is ember-cli-htmlbars expected to work in browser context? The storybook example https://github.com/storybookjs/storybook/blob/1f27b252a66e48f4f7106ef7ccc7950a5b715c32/examples/ember-cli/stories/index.stories.js#L1 throws an error at runtime

```
Cannot read property 'length' of undefined
TypeError: Cannot read property 'length' of undefined
at includes (http://localhost:6006/vendors~main.925bee91ab6e54312329.bundle.js:113614:31)
at push../node_modules/resolve-package-path/lib/should-preserve-symlinks.js.module.exports (http://localhost:6006/vendors~main.925bee91ab6e54312329.bundle.js:113622:52)
at Object. (http://localhost:6006/vendors~main.925bee91ab6e54312329.bundle.js:113404:25)
```

This happens because `ember-cli-htmlbars/utils.js` requires `hash-for-dep`
https://github.com/ember-cli/ember-cli-htmlbars/blob/aee846034a6b6772fef7675dad2156e69b40df8e/lib/utils.js#L5

`hash-for-dep/module-entry.js` requires `resolve-package-path`
https://github.com/stefanpenner/hash-for-dep/blob/f4cc06e526a36f83427b8ce1a6da2ea616112278/lib/module-entry.js#L3

Which accesses `process.execArgv` which is not defined on webpack's process shim
https://github.com/stefanpenner/resolve-package-path/blob/3e9b74512521c69609e84736e64d8e21c52a0c55/lib/should-preserve-symlinks.ts#L17

https://github.com/webpack/node-libs-browser/issues/78

Is this issue exclusive to me? Are others facing this as well? Am I missing some config

Downstream Issue: https://github.com/storybookjs/ember-cli-storybook/issues/35

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.