ember-cli / ember-cli/ember-cli-deprecation-workflow

eslint conflict with ember-cli

Open
#50 1 comment 3 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
166
Forks
44
PR merge metrics
No merged PRs in 30d

Description

By default, ember-cli adds the following to `.eslintrc.js`:
```js
// node files
{
env: {
browser: false,
node: true,
},
files: [
'ember-cli-build.js',
'testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'lib/*/index.js',
],
parserOptions: {
ecmaVersion: 2015,
sourceType: 'script',
},
},
```
That means the output to be copied to `config/deprecation-workflow.js` should have something like
```js
/* eslint-env browser */
```
or
```js
/* globals window */
```
at the top.

Or, alternatively, ember-cli-deprecation-workflow should add
```js
excludedFiles: [ 'config/deprecation-workflow.js' ],
```
to the relevant `overrides` section.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.