ember-cli / ember-cli/ember-app-blueprint
Stop hitting 3rd party API in tests
Open
- Dominant language
- JavaScript
- Stars
- 9
- Forks
- 16
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 13
Description
While working on a release I noticed that we added this: https://github.com/ember-cli/ember-app-blueprint/pull/190/changes#diff-d82802433d6969e1efb5c1252cead2d60dccf5ed05b6125ace6e81bf5381e74eR10
we really shouldn't be hitting a live API during tests, we should make sure that this isn't the case in PR reviews
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.