ember-cli / ember-cli/ember-app-blueprint

deprecation-workflow.js is included in prod builds

Open
#151 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
9
Forks
16
Avg merge
1d 2h
Merged PRs (30d)
13

Description

The blueprint tries to exclude `./app/deprecation-workflow.js` from non-development builds with a macro. But it doesn't do anything to prevent the same module from being included in the `compatModules`.

This would address the issue:

```diff
// ember-cli-build.js
return compatBuild(app, buildOnce, {
+ staticAppPaths: ['deprecation-workflow.js'],
});
```

But I don't love having this special one-off here. Perhaps it would be better to establish `./app/lib` and put all of that into `staticAppPaths` and move deprecation-workflow.js into `./app/lib`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.