ember-cli / ember-cli/create-ember-app

node-resolve seems unneeded

Open
#8 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

https://github.com/ember-cli/create-ember-app/commit/e7fa68cbadd6e43ca603a828b1799c3e6fd0de5d introduces `node-resolve` but i believe it is not needed.

`require.resolve` is already relative to the current file, so the `{ basedir: __dirname }` passed to `resolve.sync` seems to be redundant, and can simply become `require.resolve` with no extra `resolve` dep.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.