ember-cli / ember-cli/broccoli-asset-rewrite
Rewrite incorrectly applied to cases where assetPath exists with arbitrary suffix
- Dominant language
- JavaScript
- Stars
- 10
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
I've stumbled across an issue where:
```
doSomething('myapp.js.something');
```
is replaced with:
```
doSomething('myapp-48aceae9b10d78520352913b3085d74c.js.something');
```
It seems that [rewriteAssetPath](https://github.com/rickharrison/broccoli-asset-rewrite/blob/master/index.js#L100) intentionally accepts and preserves any suffix that does not contain one of: ``"`` ``'`` ``(`` ``)`` ``\`` ``>`` ``=``
Possibly there is some reason for this behavior, but I can't imagine what it is, especially since the query string is expected after this arbitrary suffix.
At the very least, it seems wrong to match additional path-like suffixes like:
* myapp.js0
* myapp.js_alt
* myapp.js.other
* myapp.js/subfile
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.