ember-cli / ember-cli/broccoli-asset-rewrite

rewriteAssetPath matches code blocks

Open
#42 10 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10
Forks
50
PR merge metrics
No merged PRs in 30d

Description

I have a project called `Ted` that uses `ember-simple-auth`. At some point in the ember build pipeline the regex `/["'\(=]{1}\s*([^"'\(\)=]*ted\.js[^"'\(\)\\>=]*)(\?[^"'\)> ]*)?\s*[\\]*\s*["'\)> ]{1}/g` is used on the vendor file. Since `ember-simple-auth` has a code part like this

``````
transition and instead transitions to the
{{#crossLink "Configuration/authenticationRoute:property"}}{{/crossLink}} if
the session is not authenticated.

```js
// app/routes/protected.js
import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';

export default Ember.Route.extend(AuthenticatedRouteMixin);
```
``````

The regex now matches

``````
"}}{{/crossLink}} if
the session is not authenticated.

```js
// app/routes/protected.js
import AuthenticatedRouteMixin from '
``````

which leads to this error

```
File: assets/vendor-6461e56a880aae756be022e1c294a533.js
The Broccoli Plugin: [AssetRewrite] failed with:
TypeError: Cannot read property '2' of null
at AssetRewrite.rewriteAssetPath (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:124:91)
at AssetRewrite.processString (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:163:24)
at AssetRewrite.processFile (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/index.js:165:31)
at asyncProcessFile (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/index.js:122:21)
at lib$rsvp$$internal$$tryCatch (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:493:16)
at lib$rsvp$$internal$$invokeCallback (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:505:17)
at /###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:1001:13
at lib$rsvp$asap$$flush (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/rsvp/dist/rsvp.js:1198:9)
at nextTickCallbackWith0Args (node.js:420:9)
at process._tickCallback (node.js:349:13)

The broccoli plugin was instantiated at:
at AssetRewrite.Plugin (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/node_modules/broccoli-plugin/index.js:7:31)
at AssetRewrite.Filter [as constructor] (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-filter/index.js:34:10)
at new AssetRewrite (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:27:10)
at AssetRewrite (/###/Projects/ted/node_modules/broccoli-asset-rev/node_modules/broccoli-asset-rewrite/index.js:22:12)
at new AssetRev (/###/Projects/ted/node_modules/broccoli-asset-rev/lib/asset-rev.js:29:10)
at AssetRev (/###/Projects/ted/node_modules/broccoli-asset-rev/lib/asset-rev.js:7:12)
at Class.module.exports.postprocessTree (/###/Projects/ted/node_modules/broccoli-asset-rev/index.js:32:14)
at /###/Projects/ted/node_modules/ember-cli/lib/broccoli/ember-app.js:506:27
at Array.forEach (native)
at EmberApp.addonPostprocessTree (/###/Projects/ted/node_modules/ember-cli/lib/broccoli/ember-app.js:504:23)
```

Any suggestions for a workaround for now?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.