ember-cli / ember-cli/broccoli-asset-rewrite

Why does rewriteAssetPath forbid trailing = (equals)?

Open
#18 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
10
Forks
50
PR merge metrics
No merged PRs in 30d

Description

The regular expression in `rewriteAssetPath()` forbids trailing equals, so this means if I have an asset key like `path/to/asset.png` this will successfully rewrite `path/to/asset.png?1234` but _not_ `path/to/asset.png?v=1234`.

My feeling is that it's a bug that the former is allowed but the latter is not, but I'm unsure as to whether they should both be allowed or forbidden,

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.