ember-cli-deploy / ember-cli-deploy/ember-cli-deploy-redis

Stash checksum and/or timestamp in Redis

Open
#37 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
17
Forks
40
PR merge metrics
No merged PRs in 30d

Description

Similar to #25, it would be fantastic if ember-deploy-redis would also stash a checksum (or the commit SHA) and/or a build date/time (or the commit timestamp) of the index to use in the the `ETag` and `Last-Modified` HTTP headers. Something like:

```
foo:index:current => '...'
foo:index:current:meta => checksum '787b3dd284fd99202adfa4e18a28126d159552c5'
timestamp 'Wed Sep 16 19:28:37 2015 +0200'
```

And then...

``` ruby
require 'sinatra'
require 'redis'

get '/' do
content_type 'text/html'
expires 3_600, :public

redis = Redis.new
index_key = redis.get("foo:current")
index_key = "foo:#{params[:index_key]}" if params[:index_key]

meta = redis.hgetall("#{index_key}:meta")
etag meta[:checksum]
last_modified meta[:timestamp]

redis.get(index_key)
end
```

Stashing the content in the same hash as the metadata would be ideal (to limit the Redis hits) but would break backwards compatibility.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.