emacs-php / emacs-php/phpactor.el
rename not working
- Dominant language
- Emacs Lisp
- Stars
- 47
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
rename doesn't seem to work properly - it doesn't recognise accessors/getters or the member data within them. eg here I rename member variable $logger to $_logger both locally and "in file" - neither correctly updates the logger() method.

Here I tried renaming from the declaration. Trying to rename from an "$this->logger" results in:-
> user-error: Expected Variable or Parameter node, got
> "Microsoft\PhpParser\Node\Expression\MemberAccessExpression"
Possibly the worst problem though is renaming a member variable that has parameters named after it. eg here I rename member var "cache" to "cache2" and it renames method parameters in that class and not the actual member variable usages.

Contributor guide
Assessment
This issue has not been assessed yet.