emacs-evil / emacs-evil/evil

unnecessary call to evil-abort-macro

Open
#688 0 comments 0 reactions 0 assignees View on GitHub
bug minor
Dominant language
Emacs Lisp
Stars
3.9k
Forks
307
PR merge metrics
No merged PRs in 30d

Description

Originally reported by: **Nick Felix (Bitbucket: [Dickby](https://bitbucket.org/Dickby), GitHub: [Dickby](https://github.com/Dickby))**

----------------------------------------

I use GNU Emacs 25.0.95.33
and Evil version 1.2.12

If I aborg an evil keyboard-macro with C-g and then switch to another buffer, window or file, i get the error message:

Error in post-command-hook (evil-abort-macro): (error "Not defining kbd macro")

instructions to reproduce the error message:

start emacs with
```
#!bash

emacs -Q
```

evaluate:

```
#!emacs lisp

(package-initialize)
(require 'evil)
(evil-mode 1)
```

open another buffer in new window:

C-x 3

C-x C-f testfile RET

start keyboard macro, type something to make it non empty and leave insert-state:

q q i something ESC

abort the macro with C-g and switch to the other window:

C-g
C-x o

and you should get the error message

----------------------------------------
- Bitbucket: https://bitbucket.org/lyro/evil/issue/688

Contributor guide

Open the contributing guide

Research direction

Reproduce with emacs -Q, package-initialize, evil-mode, and the keyboard-macro sequence described in the issue. Start at the evil-abort-macro post-command-hook entry point; done means aborting a macro and switching windows or buffers no longer reports “Not defining kbd macro”.

Written by the indexing model from the issue text.

Assessment

Tech stack
emacs-lisp
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.