elsa-workflows / elsa-workflows/elsa-studio

Fix colors in Journal and Executions tab for consistency

Open
#687 1 comment 0 reactions 0 assignees View on GitHub
triaged
Dominant language
C#
Stars
301
Forks
181
Avg merge
17h 12m
Merged PRs (30d)
42

Description

## Version
Elsa Server : 3.5.1
Elsa Studio (BlazorServer) : 3.5.1

## Issue
The primary colour in my company's branding is red. Therefore, we set the `MudTheme.PaletteLight.Primary` to red in our custom MudTheme (see the attached screenshot for reference).
The issue is that the status colour of a `Started` event in the journal takes the primary colour, which changes from one theme to another.
In our case, this makes it look like a `Started` event is an error. The same applies to the `Executions` tab, where a red badge looks like an error.

Image

## Suggest fix
### Journal event color
I suggest to change `"Started" => Color.Primary` to `"Started" => Color.Info`, in this code :

https://github.com/elsa-workflows/elsa-studio/blob/5b0f2d543773c5763481733b0a829762cdf06bc1/src/modules/Elsa.Studio.Workflows/Components/WorkflowInstanceViewer/Components/Journal.razor#L58

### Executions tab badge
Adapt the color of badge of the `Executions` tab to the executions status, in this code :

https://github.com/elsa-workflows/elsa-studio/blob/5b0f2d543773c5763481733b0a829762cdf06bc1/src/modules/Elsa.Studio.Workflows/Components/WorkflowInstanceViewer/Components/WorkflowInstanceDesigner.razor#L48

Such as it is already done for the activity badge in `ActivityWrapper.razor` :
https://github.com/elsa-workflows/elsa-studio/blob/5b0f2d543773c5763481733b0a829762cdf06bc1/src/modules/Elsa.Studio.Workflows.Designer/Components/ActivityWrappers/V2/ActivityWrapper.razor#L18

Should I create a PR for these fix ?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.