elsa-workflows / elsa-workflows/elsa-core

To avoid unexpected behaviour/errors, users should not be able to add duplicate activities to a workflow

Open
#759 1 comment 0 reactions 0 assignees View on GitHub
enhancement prio low triaged
Dominant language
C#
Stars
7.9k
Forks
1.5k
Avg merge
15h 22m
Merged PRs (30d)
114

Description

_This issue is a follow-up to a comment posted by @sfmskywalker in https://github.com/elsa-workflows/elsa-core/issues/683#issuecomment-798898997_

Currently, it is possible to create, execute & persist a workflow which contains activities that have duplicate IDs. However, this will almost certainly be troublesome in some scenarios and cause errors when `GetActivityById` is used.

This issue is to ensure that scenarios in which users try to add duplicate (same `Id`) activities to workflows are detected and prevented, such as by an exception.
* Test using the UI designer
* Test using coded workflow definitions
* Test using JSON/imported workflow definitions
* Test using existing persisted workflows (it's possible that users might have created & saved some before this issue gets done)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.