elsa-workflows / elsa-workflows/elsa-core
Make `Newtonsoft.Json` private?
Open
maintenance
triaged
- Dominant language
- C#
- Stars
- 7.9k
- Forks
- 1.5k
- Avg merge
- 15h 22m
- Merged PRs (30d)
- 114
Description
The core project uses `Newtonsoft.Json`, so any project uses elsa can use `Newtonsoft.Json` as well.
https://github.com/elsa-workflows/elsa-core/blob/2aa914044d715bf775f18ef7f4148c6323ff7a68/src/modules/Elsa.Workflows.Core/Elsa.Workflows.Core.csproj#L20
In our product, we use `System.Text.Json` and we don't want developers to see any types from `Newtonsoft.Json`.
So a private reference would be appropriate:
``` xml
```
Other projects that indeed want to use newtonsoft, they can explicitly install it.
Contributor guide
Assessment
This issue has not been assessed yet.