elsa-workflows / elsa-workflows/elsa-core

Incident handling when CompletionCallback fails

Open
#4,882 3 comments 0 reactions 0 assignees View on GitHub
elsa 3 triaged
Dominant language
C#
Stars
7.9k
Forks
1.5k
Avg merge
15h 22m
Merged PRs (30d)
114

Description

Hello,
I am using Elsa 3.0.3 to create my workflow server. Currently i'm trying to implement my own IIncidentStrategy that should try to repeat a failed activity. There is a problem in some specific scenario that i was stumbled to while testing.
I've written some custom ativities that schedule a child and do some work after the child is completed. The problem is when exception occurs in CompletionCallback (network problem for example) it happens in the child activity execution middleware and i receive the child activity context in IIncidentStrategy.HandleIncident. Moreover callback entry is now used and removed from workflow context callback entries list and there is no way (or i dont see it) to retry execution of my parent activity callback method without repeating the correctly executed child activity.

So i wonder is problem in ScheduledChildCallbackBehavior design or it works as intended and i should redesign my completion callbacks to be smaller and lighter.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.