elsa-workflows / elsa-workflows/elsa-core

MessagingBus naming improvement on the part of the "messageType"

Open
#3,666 1 comment 1 reaction 0 assignees View on GitHub
bug enhancement triaged
Dominant language
C#
Stars
7.9k
Forks
1.5k
Avg merge
15h 22m
Merged PRs (30d)
114

Description

In Azure the ServiceBus has a 50 char limitation regarding the naming:
![image](https://user-images.githubusercontent.com/5657002/216400171-b178d650-fcd6-4031-8d09-3101fcf4a2fc.png)

In our case this was causing the following error (in scenario of having free scaled instances in Kubernetes):
![image](https://user-images.githubusercontent.com/5657002/216400390-aeae670f-21f1-45f8-bee1-2dae3e73774d.png)
some logic enforced a shortened name which leads into further issues - maybe by rebus or something else..

We fixed it by reducing the application name to only 2 chars.

It would be nice if those class-names here:
https://github.com/elsa-workflows/elsa-core/blob/edfb2d635f69dbda096cf9c80fda81422830af3f/src/core/Elsa.Core/Services/Messaging/ServiceBusFactory.cs#L118

would get replaced by a e.g. Interface/Attribute which implements a method for getting a shorter name instead - to save space for e.g. the random Hostname parts of a Kubernetes-Pod and such things...

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.