elrumordelaluz / elrumordelaluz/reactour

mutationObservables is not working as expected

Open
#565 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
4.1k
Forks
350
PR merge metrics
No merged PRs in 30d

Description

@elrumordelaluz
I added a step like { //step selector: '.shipments-grid-tour', mutationObservables: [".indextable"], content: ' This is the table where we can see all the data.', },
But whenever there is a change in the DOM, does not affect make the react tour to re-render, where I fail to place the popup in the right place.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with the step configuration using mutationObservables: [".indextable"] and inspect the mutationObservables entry point in the React tour. Confirm what happens when the .indextable DOM changes; done means the tour re-renders and the popup is placed correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.