elonen / elonen/js-sky-sim

Wrong timezone conversion to radian

Open
#1 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
HTML
Stars
19
Forks
1
PR merge metrics
No merged PRs in 30d

Description

I believe you forgot to multiply the timezone by 15 before converting it to radian.

Line 164 in sky-sim.html:
`var time_zone_meridian = deg2rad(parseFloat($('#tz_sm').val()));`

There were also some unused variables in your code, like "tz_offset", which I believe was faulty because of the wrong timezone calculation.

Anyway, super kudos for your amazing project.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.