elm-explorations / elm-explorations/test

Fuzz.forcedChoice: don't reject unexpected values?

Open
#222 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Elm
Stars
244
Forks
40
Avg merge
1d 23h
Merged PRs (30d)
2

Description

@CoderDennis has found this when reading through the source code.

`Fuzz.forcedChoice` [doesn't reject the value](https://github.com/DRMacIver/minithesis/blob/f5d00372fc4ee0b24019004df3c4ccfb380762e7/minithesis.py#L239-L243) in the original Python minithesis repo but [it does in our implementation](https://github.com/elm-explorations/test/blob/cda4e92057929a86a11d74ab67c4f4944bf762f0/src/Fuzz.elm#L1611-L1616) (when using a Hardcoded RandomRun).

This probably results in more failed generations during shrinking than necessary. We likely should just ignore the current value instead of checking its value.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.