elliotchance / elliotchance/concise

vendor/ path is hardcoded

Open
#345 0 comments 0 reactions 0 assignees View on GitHub
Component: Core Size: 1 (Small) Type: Bug
Dominant language
PHP
Stars
45
Forks
3
PR merge metrics
No merged PRs in 30d

Description

Got the following error running Consise:

```
vendor-dev/bin/concise --configuration tests/phpunit.xml --group "translations"
PHP Warning: file_get_contents(/var/www/my-project/vendor-dev/elliotchance/concise/src/Concise/Core/../../../../../../vendor/composer/installed.json): failed to open stream: No such file or directory in /var/www/mccs/vendor-dev/elliotchance/concise/src/Concise/Core/Version.php on line 39
```

`findVendorFolder()` should respect `COMPOSER_VENDOR_DIR` or even better just use a relative path.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in src/Concise/Core/Version.php, especially findVendorFolder() and the code around line 39. Reproduce the reported vendor-dev/bin/concise command with tests/phpunit.xml and the translations group, then verify the completed change works with COMPOSER_VENDOR_DIR or the intended relative path.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.