elixirs / elixirs/faker

Faker.Name.PtBr.first_name/0 is undefined

Open
#385 2 comments 4 reactions 0 assignees View on GitHub
Dominant language
Elixir
Stars
1.2k
Forks
261
Avg merge
2d 16h
Merged PRs (30d)
13

Description

Hello guys, after updating to version 0.14, `Faker.Name.PtBr.first_name/0` is not working

I see that `Faker.Name` is deprecated in favour of `Faker.Person`.

But the changelog is not warning about that break change:
`Faker.Namer.{other langs}` removed https://github.com/elixirs/faker/commit/0256548f9955136bdff9bd81b8acd8bb3f864e51#diff-3802f66f490ca4c5f190a8ac777ad20265cdb2cb626c2e665a8e9c8e174c30ddL1

Shouldn’t it be good to add it to the changelog? Or add back the modules with the deprecation warning like `Faker.Name`?

Contributor guide

Open the contributing guide

Research direction

Inspect the changelog and the removed Faker.Name language modules referenced by commit 0256548. Compare the break with the existing Faker.Name deprecation approach, then determine whether the documented migration is sufficient or whether compatibility modules should be restored. Done means the version 0.14 change and migration path are clearly documented or the chosen compatibility behavior is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
elixir
Domain
testing, tooling
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.