elixir-europe / elixir-europe/MARS
BioSamples and ENA Repository services only accept ontology annotations for parameterValues while ISA supports also str and int
- Dominant language
- Java
- Stars
- 10
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
The Lombok value type at this line only accepts ontology annotations:
https://github.com/elixir-europe/MARS/blob/5d84a547598b50751615876429d19b66fce10255/repository-services/isajson-biosamples/src/main/java/com/elixir/biohackaton/ISAToSRA/model/Value.java#L8C6-L8C33
This causes an error when the submitted ISA-JSON is a number or string:
```
com.fasterxml.jackson.databind.exc.MismatchedInputException: Cannot construct instance of `com.elixir.biohackaton.ISAToSRA.model.Value` (although at least one Creator exists): no int/Int-argument constructor/factory method to deserialize from Number value
```
According to the ISA-JSON specification, the value can be "number," "string," or "ontology annotation":
https://github.com/ISA-tools/isa-api/blob/972f4d81642eca30da5266b400b7cbd222c65848/isatools/resources/schemas/isa_model_version_1_0_schemas/core/process_parameter_value_schema.json#L15
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.