eligrey / eligrey/classList.js

Doesn't work in IE 8.0.7601.17514 / Win 7

Open
#36 11 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
1.1k
Forks
226
PR merge metrics
No merged PRs in 30d

Description

I've just tried your polyfill in the above version and it doesn't work. It fails here: https://github.com/eligrey/classList.js/blob/master/classList.js#L174

Turns out the exception thrown isn't what you were expecting. The exception has no `number` property. It is a `TypeError` stating that "getters & setters can not be defined on this javascript engine".

Removing the condition `if (ex.number === -0x7FF5EC54) { ...` fixes the problem.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.