eligrey / eligrey/FileSaver.js

New version popup page on OSX Chrome

Open
#626 0 comments 3 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
22k
Forks
4.3k
PR merge metrics
No merged PRs in 30d

Description

It works fine on old version, but in new version, it popup two empty pages before download.

It caused by `!isWebKit`( https://github.com/eligrey/FileSaver.js/blob/master/dist/FileSaver.js#L94 ).

Why change this line? In OSX, Browser or electron apps are share same `userAgent`, may be should use other way to check.

It seems effect OSX Chrome.

https://github.com/eligrey/FileSaver.js/commit/0a2e868b48b6d745a0f2b9bf448f9226925efcd0

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.