eligrey / eligrey/FileSaver.js

Google Closure compiler warning about changing a constant location

Open
#603 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
22k
Forks
4.3k
PR merge metrics
No merged PRs in 30d

Description

I'm getting this warning when using the library in a ClojureScript project (where all JS code is passed through the Google Closure Compiler):
```
Resource: node_modules/file-saver/dist/FileSaver.min.js:2:2315
constant location assigned a value more than once.
Original definition at externs.zip//window.js:52
```
Seems like it's this line in the unminified source: https://github.com/eligrey/FileSaver.js/blame/master/dist/FileSaver.js#L163

According to [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/API/Window/location), `window.location` is indeed read-only.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.