elementor / elementor/static-html-output

Issue publishing to a private S3 bucket.

Open
#120 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
128
Forks
35
PR merge metrics
No merged PRs in 30d

Description

These days S3 buckets default to private. If you use CloudFront infront of the bucket (for TLS support, caching support, lambda@edge for redirects etc etc etc) you can choose to leave the bucket private and give CloudFlare access to the bucket.

The issue is even though wp2static s3 addon knows that i'm using https in my Destination URL and/or using a CF invalidation token it will still try and read from the bucket directly instead of trying to access the file via the sites Destination URL resulting in a `Failed during "Deploying files to S3", please consult the Help tab for where to get assistance.` message.

Enabling public read access on the bucket resolves the issue.

So I propose that either the docs get updated to include this info or the addon get updated to check check the distantion URL instead of the raw s3 bucket url.

I can dig into the code to find the exact place it fails on, but it won't be till later this week/weekend before I will have the time to dig.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.