elementor / elementor/lokl-cli

Unable to find image 'lokl/lokl:php8-5.0.0-' locally

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
66
Forks
7
PR merge metrics
No merged PRs in 30d

Description

When skipping the wizard by setting env vars if you follow the example and set `lokl_php_ver=php8-5.0.0 \` you get the error

```
Unable to find image 'lokl/lokl:php8-5.0.0-' locally
```

Notice the extra `-` at the end. `$LOKL_RELEASE_VERSION` on [cli.sh#L34](https://github.com/leonstafford/lokl-cli/blob/2370639be5b1e4ff417ff7761234822679bd9c0b/cli.sh#L34) doesn't seem to be available at that point. Nor should it be appended if you follow the example.

I suppose that line should just be:

```sh
echo "$lokl_php_ver"
```

which works.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.