elementor / elementor/elementor
Site Builder Header breaking after Elementor v3.33.3 update
- Dominant language
- PHP
- Stars
- 7.1k
- Forks
- 1.6k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 193
Description
### Description
Hello Elementor Team,
We’re experiencing an issue after Elementor v3.33.3 release that affects our site builder header functionality.
Problem: Our custom site builder header breaks on Elementor pages. After investigation, we found that Elementor disables WordPress template buffering with this code:
if ( version_compare( get_bloginfo( 'version' ),'6.9', '>=' ) ){add_filter( 'wp_should_output_buffer_template_for_enhancement', '__return_false', 1 ); }
This prevents our site builder header from rendering correctly. We’ve also observed that this filter can impact other theme or plugin-based site builders that rely on WordPress template buffering, suggesting this may be a broader compatibility concern.
Our Solution: We’re re-enabling buffering when our site builder header is active. However, we’re concerned this might break some Elementor functionality, as we’re not sure why you introduced this change in the first place.
### Steps to reproduce
1. Install Responsive Theme and Responsive Plus - Starter Templates Plugin.
2. Go to Responsive Dashboard through admin dashboard, scroll down and enable 'Site Builder' Toggle.
3. Now you'll be able to see Site Builder option as a sub menu under Responsive Menu.
4. Create a header layout, import a wordpress provided pattern through clicking on '+' sign on editor and then moving to 'Patterns' > Headers > Import any header out of them.
5. Click save and make sure the display condition is on for 'Entire Website' through the Responsive icon at the top in the editor.
6. Create a page with Elementor as well as normal Gutenberg editor, you'll see the header breaking on Elementor page only.
7. Now remove the filter logic in Elementor through plugin editor and you'll see the header working properly.
### Expected behavior
if ( version_compare( get_bloginfo( 'version' ),'6.9', '>=' ) ) {
add_filter( 'wp_should_output_buffer_template_for_enhancement', '__return_false', 1 );
}
The above code is breaking the header as it stops the wordpress own buffer mechanism, this update impact compatibility with other plugins which shouldn't be the case.
### Elementor System Info
```txt
Server Environment:
Tested on both tastewp temporary wordpress site as well as fresh local WP instance.
Wordpress Version:
6.9
Elementor Version:
3.33.3
Theme Installed:
Responsive
Plugins Installed:
Elementor
Responsive Plus - Starter Templates
```
### Agreement
- [x] I confirm I have read and followed all the guidelines and instructions outlined in the Elementor Bug Report form.
- [x] I agree that my issue may be closed without further action if it doesn't meet all the requirements outlined in the Elementor Bug Report form.
Contributor guide
Assessment
This issue has not been assessed yet.