elementor / elementor/elementor

🐘 🐞 Elementor Pro - PHP 8.x compatibility issues

Open
#23,927 0 comments 1 reaction 0 assignees View on GitHub
compatibility/php-8 component/code editor mod/e* product/pro
Dominant language
PHP
Stars
7.1k
Forks
1.6k
Avg merge
1d 5h
Merged PRs (30d)
193

Description

### Prerequisites

- [X] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
- [X] The issue still exists against the latest stable version of Elementor.

### Description

In the Elementor Pro Plugin
/core/editor/editor.php::118
Using ${var} in strings is deprecated, use {$var} instead.
This breaks WPCLI functionality on PHP 8.2

Related to:
https://github.com/elementor/elementor/issues/21087

### Steps to reproduce

1. Go to wp-config.php enable debug
define( 'WP_DEBUG', true );
define( 'WP_DEBUG_DISPLAY', true );

2. Try do something with WP-CLI to got issue:

3. Example Update Plugin, Core, Theme

### Isolating the problem

- [X] This bug happens with only Elementor plugin active (and Elementor Pro).
- [X] This bug happens with a Blank WordPress theme active ([Hello theme](https://wordpress.org/themes/hello-elementor/)).
- [X] I can reproduce this bug consistently following the steps above.

### System Info

Click to reveal

````txt


== Server Environment ==
Operating System: Linux
Software: Apache
MySQL version: MySQL Community Server - GPL v8.0.34
PHP Version: 8.2.10
PHP Memory Limit: 128M
PHP Max Input Vars: 1000
PHP Max Post Size: 100M
GD Installed: Yes
ZIP Installed: Yes
Write Permissions: All right
Elementor Library: Connected

== WordPress Environment ==
Version: 6.3.1
Site URL:
Home URL:
WP Multisite: No
Max Upload Size: 100 MB
Memory limit: 40M
Max Memory limit: 1024M
Permalink Structure: /%category%/%postname%/
Language: en-US
Timezone: 0
Debug Mode: Inactive

== Theme ==
Name: Hello Elementor
Version: 2.8.1
Author: Elementor Team
Child Theme: No

== User ==
Role: administrator
WP Profile lang: en_US
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36 Edg/117.0.2045.43

== Active Plugins ==
Advanced Custom Fields
Version: 6.2.1
Author: WP Engine

Asset CleanUp Pro: Page Speed Booster
Version: 1.2.4.3
Author: Gabe Livan

Auto Upload Images
Version: 3.3.2
Author: Ali Irani

Blog2Social: Social Media Auto Post & Scheduler
Version: 7.3.1
Author: Blog2Social, Adenion

Cloudflare
Version: 4.12.2
Author: Cloudflare, Inc.

Code Snippets
Version: 3.5.0
Author: Code Snippets Pro

DynamicConditions
Version: 1.6.2
Author: RTO GmbH

Elementor
Version: 3.16.4
Author: Elementor.com

Elementor Pro
Version: 3.16.2
Author: Elementor.com

Essential Addons for Elementor
Version: 5.8.9
Author: WPDeveloper

Essential Addons for Elementor - Pro
Version: 5.6.1
Author: WPDeveloper

Imagify
Version: 2.1.2
Author: Imagify – Optimize Images & Convert WebP

JSON Feed
Version: 1.4.3
Author: Manton Reece and Daniel Jalkut

Newsletter
Version: 7.9.5
Author: Stefano Lissa & The Newsletter Team

Newsletter - Addons Manager
Version: 1.2.0
Author: The Newsletter Team

Newsletter - Amazon SES
Version: 1.4.2
Author: The Newsletter Team

Newsletter - API v1 and v2
Version: 2.3.5
Author: The Newsletter Team

Newsletter - Elementor Addon
Version: 1.0.9
Author: The Newsletter Team

Newsletter - Import
Version: 1.4.1
Author: The Newsletter Team

Newsletter - Instasend (BETA)
Version: 1.0.3
Author: The Newsletter Team

Permalink Manager Pro
Version: 2.4.1.5
Author: Maciej Bis

Premium Addons for Elementor
Version: 4.10.11
Author: Leap13

Premium Addons PRO
Version: 2.9.7
Author: Leap13

Safe SVG
Version: 2.2.0
Author: 10up

Site Kit by Google
Version: 1.110.0
Author: Google

Templately
Version: 2.2.5
Author: Templately

Wicked Folders
Version: 2.18.18
Author: Wicked Plugins

WP Rocket
Version: 3.15.1
Author: WP Media

Yoast SEO
Version: 21.2
Author: Team Yoast

== Must-Use Plugins ==
Asset CleanUp Pro: Plugin Filtering
Version: 1.0
Author: Gabriel Livan

== Features ==
Custom Fonts: 1
Custom Icons: 0

== Integrations ==

== Elementor Experiments ==
Optimized DOM Output: Active by default
Improved Asset Loading: Active by default
Improved CSS Loading: Active
Inline Font Icons: Active
Additional Custom Breakpoints: Active by default
admin_menu_rearrangement: Inactive by default
Flexbox Container: Active
Upgrade Swiper Library: Inactive by default
Grid Container: Inactive by default
Default to New Theme Builder: Active by default
Hello Theme Header & Footer: Active by default
Editor Top Bar: Inactive by default
Landing Pages: Active by default
Nested Elements: Inactive by default
Lazy Load Background Images: Active
Global Style Guide: Inactive by default
Page Transitions: Active by default
Notes: Active by default
Form Submissions: Active by default
Scroll Snap: Active by default
Menu: Inactive by default
Taxonomy Filter: Inactive by default

== Log ==

Log: showing 20 of 292023-09-24 16:01:40 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor Pro',
'from' => '3.15.1',
'to' => '3.16.2',
)]
2023-09-24 16:01:40 [info] Elementor/Upgrades - _on_each_version Start
2023-09-24 16:01:40 [info] Elementor/Upgrades - _on_each_version Finished
2023-09-24 16:01:40 [info] Elementor/Upgrades - _v_3_16_0_container_updates Start
2023-09-24 16:01:41 [info] Elementor/Upgrades - _v_3_17_0_site_settings_updates Start
2023-09-24 16:01:41 [info] Elementor/Upgrades - _v_3_17_0_site_settings_updates Finished
2023-09-24 16:01:41 [info] Elementor/Upgrades - _on_each_version Start
2023-09-24 16:01:41 [info] Elementor/Upgrades - _on_each_version Finished
2023-09-24 16:01:41 [info] Elementor/Upgrades - _v_3_16_0_container_updates Start
2023-09-24 16:01:41 [info] Elementor/Upgrades - _v_3_16_0_container_updates Finished
2023-09-24 16:01:42 [info] Elementor/Upgrades - _v_3_17_0_site_settings_updates Start
2023-09-24 16:01:42 [info] Elementor/Upgrades - _v_3_17_0_site_settings_updates Finished
2023-09-24 16:01:42 [info] Elementor/Upgrades - _on_each_version Start
2023-09-24 16:01:42 [info] Elementor/Upgrades - _on_each_version Finished
2023-09-24 16:01:42 [info] Elementor/Upgrades - _v_3_16_0_container_updates Start
2023-09-24 16:01:42 [info] Elementor/Upgrades - _v_3_16_0_container_updates Finished
2023-09-24 16:01:43 [info] Elementor/Upgrades - _v_3_17_0_site_settings_updates Finished
2023-09-24 16:01:43 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor',
'from' => '3.15.3',
'to' => '3.16.4',
)]
2023-09-24 16:01:43 [info] Elementor data updater process has been queued. [array (
'plugin' => 'Elementor Pro',
'from' => '3.15.1',
'to' => '3.16.2',
)]
2023-09-24 16:01:49 [info] Elementor data updater process has been queued. [array (
'plugin' => 'Elementor',
'from' => '3.15.3',
'to' => '3.16.4',
)]

PHP: showing 9 of 9PHP: 2023-09-24 16:01:39 [notice X 2049]../wp-content/plugins/elementor-pro/core/editor/editor.php::118] Using ${var} in strings is deprecated, use {$var} instead [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-09-24 16:02:02 [notice X 2]../wp-content/plugins/elementor-pro/modules/custom-css/module.php::76] trim(): Passing null to parameter #1 ($string) of type string is deprecated [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-09-24 16:03:07 [notice X 177]../wp-content/plugins/elementor/includes/elements/container.php::43] Creation of dynamic property Elementor\Includes\Elements\Container::$logical_dimensions_inline_end is deprecated [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-09-24 16:05:09 [warning X 3]../wp-content/plugins/elementor/core/page-assets/data-managers/font-icon-svg/font-awesome.php::50] Trying to access array offset on value of type null [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-09-24 16:05:52 [warning X 10]../wp-content/plugins/elementor-pro/modules/dynamic-tags/tags/post-featured-image.php::36] Trying to access array offset on value of type bool [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-09-24 16:48:30 [notice X 13]../wp-content/plugins/elementor/includes/elements/container.php::42] Creation of dynamic property Elementor\Includes\Elements\Container::$logical_dimensions_inline_start is deprecated [array (
'trace' => '
#0: ../wp-content/plugins/elementor/includes/elements/container.php(42): Elementor\Core\Logger\Manager -> rest_error_handler()
#1: ../wp-content/plugins/elementor/includes/managers/elements.php(89): Elementor\Includes\Elements\Container -> __construct()
#2: ../wp-content/plugins/elementor/core/base/document.php(1733): Elementor\Elements_Manager -> create_element_instance()
#3: ../wp-content/plugins/elementor/core/base/document.php(1134): Elementor\Core\Base\Document -> print_elements()
#4: ../wp-content/plugins/elementor/includes/frontend.php(1179): Elementor\Core\Base\Document -> print_elements_with_wrapper()
',
)]
PHP: 2023-09-24 16:48:30 [notice X 13]../wp-content/plugins/elementor/includes/elements/container.php::43] Creation of dynamic property Elementor\Includes\Elements\Container::$logical_dimensions_inline_end is deprecated [array (
'trace' => '
#0: ../wp-content/plugins/elementor/includes/elements/container.php(43): Elementor\Core\Logger\Manager -> rest_error_handler()
#1: ../wp-content/plugins/elementor/includes/managers/elements.php(89): Elementor\Includes\Elements\Container -> __construct()
#2: ../wp-content/plugins/elementor/core/base/document.php(1733): Elementor\Elements_Manager -> create_element_instance()
#3: ../wp-content/plugins/elementor/core/base/document.php(1134): Elementor\Core\Base\Document -> print_elements()
#4: ../wp-content/plugins/elementor/includes/frontend.php(1179): Elementor\Core\Base\Document -> print_elements_with_wrapper()
',
)]
PHP: 2023-09-24 16:48:30 [notice X 16]../wp-content/plugins/elementor/includes/elements/container.php::42] Creation of dynamic property Elementor\Includes\Elements\Container::$logical_dimensions_inline_start is deprecated [array (
'trace' => '
#0: ../wp-content/plugins/elementor/includes/elements/container.php(42): Elementor\Core\Logger\Manager -> rest_error_handler()
#1: ../wp-content/plugins/elementor/includes/managers/elements.php(89): Elementor\Includes\Elements\Container -> __construct()
#2: ../wp-content/plugins/elementor/includes/base/element-base.php(361): Elementor\Elements_Manager -> create_element_instance()
#3: ../wp-content/plugins/elementor/includes/base/element-base.php(1480): Elementor\Element_Base -> add_child()
#4: ../wp-content/plugins/elementor/includes/base/element-base.php(300): Elementor\Element_Base -> init_children()
',
)]
PHP: 2023-09-24 16:48:30 [notice X 16]../wp-content/plugins/elementor/includes/elements/container.php::43] Creation of dynamic property Elementor\Includes\Elements\Container::$logical_dimensions_inline_end is deprecated [array (
'trace' => '
#0: ../wp-content/plugins/elementor/includes/elements/container.php(43): Elementor\Core\Logger\Manager -> rest_error_handler()
#1: ../wp-content/plugins/elementor/includes/managers/elements.php(89): Elementor\Includes\Elements\Container -> __construct()
#2: ../wp-content/plugins/elementor/includes/base/element-base.php(361): Elementor\Elements_Manager -> create_element_instance()
#3: ../wp-content/plugins/elementor/includes/base/element-base.php(1480): Elementor\Element_Base -> add_child()
#4: ../wp-content/plugins/elementor/includes/base/element-base.php(300): Elementor\Element_Base -> init_children()
',
)]

== Elementor - Compatibility Tag ==

Elementor Pro: Compatibility not specified
Essential Addons for Elementor: Compatibility not specified
Essential Addons for Elementor - Pro: Compatibility not specified
Newsletter - Elementor Addon: Compatibility not specified
Premium Addons for Elementor: Compatibility not specified

== Elementor Pro - Compatibility Tag ==

````

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.