elementor / elementor/elementor

🐞 Bug Report: Twitter Share Button not escaping excerpts

Open
#21,764 0 comments 0 reactions 0 assignees View on GitHub
bug compatibility/3rd-party mod/b* widget/pro/share-buttons
Dominant language
PHP
Stars
7.1k
Forks
1.6k
Avg merge
1d 5h
Merged PRs (30d)
193

Description

### Prerequisites

- [X] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
- [X] The issue still exists against the latest stable version of Elementor.

### Description

Share Widget Twitter Button is not escaping / urlencoding post excerpts. e.g. when symbols like an ampersand & and percent % are present, the twitter share button fails to pass the excerpt contents correctly to twitter in the text parameter.

Very frustrating when one is trying to keep to the character limit and need to abbreviate 'and' to '&' etc.

### Steps to reproduce

1. Create a post
2. Enter an excerpt that contains & or %
3. Insert the Share Buttons widget
4. Publish the post
5. Click the twitter icon

### Isolating the problem

- [X] This bug happens with only Elementor plugin active (and Elementor Pro).
- [X] This bug happens with a Blank WordPress theme active ([Hello theme](https://wordpress.org/themes/hello-elementor/)).
- [X] I can reproduce this bug consistently following the steps above.

### System Info


== Server Environment ==
Operating System: Linux
Software: LiteSpeed
MySQL version: MariaDB Server v10.3.37
PHP Version: 7.4.33
PHP Memory Limit:
PHP Max Input Vars: 1000
PHP Max Post Size: 20M
GD Installed: Yes
ZIP Installed: Yes
Write Permissions: All right
Elementor Library: Connected

== WordPress Environment ==
Version: 6.1.1
Site URL:
Home URL:
WP Multisite: No
Max Upload Size: 10 MB
Memory limit: 40M
Max Memory limit: 256M
Permalink Structure: /%year%/%monthnum%/%day%/%postname%/
Language: en-CA
Timezone: America/Vancouver
Admin Email:
Debug Mode: Inactive

== Theme ==
Name: Hello Elementor
Version: 2.6.1
Author: Elementor Team
Child Theme: No

== User ==
Role: administrator
WP Profile lang: en_CA
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/111.0.0.0 Safari/537.36 Edg/111.0.1661.51

== Active Plugins ==
Akismet Anti-Spam
Version: 5.1
Author: Automattic

All in One SEO
Version: 4.3.3
Author: All in One SEO Team

Complianz | GDPR/CCPA Cookie Consent
Version: 6.4.2.1
Author: Really Simple Plugins

Custom Post Type UI
Version: 1.13.4
Author: WebDevStudios

Elementor
Version: 3.11.5
Author: Elementor.com

Elementor Pro
Version: 3.11.7
Author: Elementor.com

Featured Image Admin Thumb
Version: 1.6
Author: Sean Hayes

Forminator
Version: 1.22.1
Author: WPMU DEV

Google Analytics for WordPress by MonsterInsights
Version: 8.13.1
Author: MonsterInsights

iThemes Security
Version: 8.1.5
Author: iThemes

Meta pixel for WordPress
Version: 3.0.8
Author: Facebook

Newsletter, SMTP, Email marketing and Subscribe forms by Sendinblue
Version: 3.1.58
Author: Sendinblue

Obfuscate Email
Version: 3.8.1
Author: Scott Reilly

Open Links In New Tab
Version: 1.1.0
Author: Reza Khan

Password Protected
Version: 2.6.2
Author: WPExperts

Post SMTP
Version: 2.4.5
Author: Post SMTP

Post Type Switcher
Version: 3.2.1
Author: Triple J Software, Inc.

Redirection
Version: 5.3.9
Author: John Godley

SpeakOut! Email Petitions
Version: 4.1.3.1
Author: Steve D - 123host.au

WPCode Lite
Version: 2.0.8.1
Author: WPCode

== Elements Usage ==

archive : 1
heading : 1
posts : 1
text-editor : 2
footer : 2
heading : 1
icon-box : 4
icon-list : 2
nav-menu : 4
text-editor : 2
header : 1
icon : 1
theme-site-logo : 1
page : 1
divider : 3
heading : 6
icon : 1
spacer : 1
text-editor : 4
popup : 5
button : 1
form : 1
heading : 3
icon : 4
icon-box : 8
icon-list : 1
nav-menu : 1
search-form : 1
share-buttons : 1
shortcode : 1
spacer : 4
text-editor : 3
theme-site-logo : 1
section : 6
button : 1
form : 1
heading : 3
icon : 2
icon-box : 7
post-info : 1
share-buttons : 2
spacer : 3
text-editor : 3
theme-post-title : 1
single : 3
button : 2
heading : 4
post-info : 3
post-navigation : 1
posts : 2
share-buttons : 2
spacer : 2
text-editor : 3
theme-post-content : 2
theme-post-featured-image : 1
widget : 0
icon-list : 2
share-buttons : 1
wp-post : 53
blockquote : 2
button : 46
facebook-embed : 1
heading : 4
image : 4
text-editor : 89
toggle : 1
video : 3
wp-page : 11
blockquote : 1
button : 16
divider : 3
facebook-button : 1
form : 1
heading : 44
icon-box : 4
image : 12
menu-anchor : 2
posts : 3
search-form : 1
share-buttons : 5
shortcode : 4
slides : 1
social-icons : 2
spacer : 10
testimonial-carousel : 2
text-editor : 56
video : 2
single-page : 1
divider : 3
heading : 4
icon : 1
spacer : 1
text-editor : 3
theme-post-content : 1
theme-post-title : 1
search-results : 1
heading : 1
posts : 1
search-form : 1
spacer : 1
loop-item : 1
button : 1
post-info : 1
theme-post-excerpt : 1
theme-post-featured-image : 1
theme-post-title : 1

== Settings ==

cpt_support: post, page
allow_tracking: yes
unfiltered_files_upload: 1
font_display: swap

== Features ==
Custom Fonts: 0
Custom Icons: 0

== Integrations ==

recaptcha_v3: Active

== Elementor Experiments ==
Optimized DOM Output: Active by default
Improved Asset Loading: Active by default
Improved CSS Loading: Active by default
Inline Font Icons: Inactive by default
Accessibility Improvements: Active by default
Additional Custom Breakpoints: Active by default
admin_menu_rearrangement: Inactive by default
Flexbox Container: Inactive by default
Upgrade Swiper Library: Inactive by default
Default to New Theme Builder: Active by default
Hello Theme Header & Footer: Active by default
Editor V2: Inactive by default
Landing Pages: Active by default
Nested Elements: Inactive by default
Lazy Load Background Images: Inactive by default
Save as Default: Active by default
Page Transitions: Active by default
Notes: Active by default
Loop: Active by default
Form Submissions: Active by default
Scroll Snap: Active by default
Mega Menu: Inactive by default

== Log ==

JS: showing 1 of 1JS: 2023-02-18 21:48:58 [error X 1][https:///wp/wp-content/plugins/elementor/assets/js/frontend.min.js?ver=3.11.1:2:32297] elementor.settings.page is undefined

Log: showing 20 of 402023-03-13 06:07:32 [info] elementor-pro::elementor_pro_updater Started
2023-03-13 06:07:32 [info] Elementor Pro/Upgrades - _on_each_version Start
2023-03-13 06:07:32 [info] Elementor Pro/Upgrades - _on_each_version Finished
2023-03-13 06:07:32 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor Pro',
'from' => '3.11.4',
'to' => '3.11.5',
)]
2023-03-13 06:07:33 [info] Elementor data updater process has been queued. [array (
'plugin' => 'Elementor Pro',
'from' => '3.11.4',
'to' => '3.11.5',
)]
2023-03-14 06:03:30 [info] Elementor data updater process has been queued. [array (
'plugin' => 'Elementor',
'from' => '3.11.4',
'to' => '3.11.5',
)]
2023-03-14 06:03:32 [info] elementor::elementor_updater Started
2023-03-14 06:03:32 [info] Elementor/Upgrades - _on_each_version Start
2023-03-14 06:03:34 [info] Elementor/Upgrades - _on_each_version Finished
2023-03-14 06:03:34 [info] Elementor/Upgrades - _on_each_version Start
2023-03-14 06:03:34 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor',
'from' => '3.11.4',
'to' => '3.11.5',
)]
2023-03-17 22:10:08 [info] elementor-pro::elementor_pro_updater Started
2023-03-17 22:10:08 [info] Elementor Pro/Upgrades - _on_each_version Start
2023-03-17 22:10:08 [info] Elementor Pro/Upgrades - _on_each_version Finished
2023-03-17 22:10:08 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor Pro',
'from' => '3.11.5',
'to' => '3.11.6',
)]
2023-03-24 06:53:15 [info] Elementor data updater process has been queued. [array (
'plugin' => 'Elementor Pro',
'from' => '3.11.6',
'to' => '3.11.7',
)]
2023-03-24 06:53:16 [info] elementor-pro::elementor_pro_updater Started
2023-03-24 06:53:16 [info] Elementor Pro/Upgrades - _on_each_version Start
2023-03-24 06:53:16 [info] Elementor Pro/Upgrades - _on_each_version Finished
2023-03-24 06:53:16 [info] Elementor data updater process has been completed. [array (
'plugin' => 'Elementor Pro',
'from' => '3.11.6',
'to' => '3.11.7',
)]

PHP: showing 2 of 2PHP: 2023-03-13 06:07:32 [warning X 1][/home/recoverym/public_html/wp/wp-content/plugins/elementor/core/files/manager.php::111] unlink(/home/recoverym/public_html/wp/wp-content/uploads/elementor/css/post-139.css): No such file or directory [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]
PHP: 2023-03-14 06:03:32 [warning X 1][/home/recoverym/public_html/wp/wp-content/plugins/elementor/core/files/manager.php::111] unlink(/home/recoverym/public_html/wp/wp-content/uploads/elementor/css/post-739.css): No such file or directory [array (
'trace' => '
#0: Elementor\Core\Logger\Manager -> shutdown()
',
)]

== Elementor - Compatibility Tag ==

Elementor Pro: Compatible

== Elementor Pro - Compatibility Tag ==

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.