elementary / elementary/settings-desktop

No backgrounds shown with system backgrounds dir has subdirectories

Open
#246 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Vala
Stars
37
Forks
24
Avg merge
3d 12h
Merged PRs (30d)
4

Description

## Prerequisites
- [x] I have searched open and closed issues for duplicates.

I recalled https://github.com/elementary/switchboard-plug-pantheon-shell/issues/157 but that issue was fixed and there's been no `new_for_path` -> `new_for_uri`

## Describe the bug
This has been reported on NixOS https://github.com/NixOS/nixpkgs/issues/100293.
If there's subdirectories at the system backgrounds directory no wallpapers are loaded from there.

The layout of the system backgrounds directory would be like
```
/run/current-system/sw/share/backgrounds
nixos/
...bunch of elementary wallpapers
```

From the output there seems to be nothing of importance.

### To Reproduce
Steps to reproduce the behavior:
1. At your system background directory `$XDG_DATA_DIRS/share/backgrounds` have a subdirectory with pictures in it
2. Click on Wallpapers
3. Just a black background
4. Now delete that subdirectory and repeat. It's magic and now the wallpapers are there.

I actually did this with no local backgrounds btw.

### Expected behavior
It doesn't matter what directory structure at the backgrounds directory is, everything that is an image is loaded.

### Screenshots or screen recordings

![Screenshot from 2020-10-07 15-38-20](https://user-images.githubusercontent.com/91113/95708488-b77ed800-0c5c-11eb-929b-7cdd625a6c41.png)

## Platform Information

OS: NixOS
OS Version: NixOS 20.09 and 21.03-pre-git

- [ ] I'm using the latest version from git that I've manually compiled
- [x] I'm using the latest released stable version

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/94184738-no-backgrounds-shown-with-system-backgrounds-dir-has-subdirectories?utm_campaign=plugin&utm_content=tracker%2F57462545&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F57462545&utm_medium=issues&utm_source=github).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.