elementary / elementary/settings-daemon

systemd SystemUpdates trigger: ConditionACPower can cause no checking for updates for a long time

Open
#236 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
Vala
Stars
19
Forks
15
Avg merge
5h 8m
Merged PRs (30d)
2

Description

### What Happened?

Checking for updates is triggered once a day by a systemd timer that starts the `io.elementary.settings-daemon.system-update.service`. However the service has the condition `ACPower=true`. This means if you happen to be not plugged in when the timer runs you have to wait another day for a new chance to check for updates.

I usually only charge my laptop when it's empty so by default it's not plugged in. This means that my last update check was 8 days ago and I think that even was a manual one.

### Steps to Reproduce

1. run elementary OS on a laptop
2. only charge it when it's empty so don't have it plugged in by default
3. observe no updates check

### Expected Behavior

I think for checking for updates we can just remove `ConditionACPower=true`. It doesn't run very often so it won't be too straining and nothing bad happens when you run out of battery. The optimal solution would of course be a way to have systemd automatically start the service once the condition becomes met if it failed to start because of it. @ryonakano any idea if that's possible?

### OS Version

8.x (Circe)

### OS Architecture

amd64 (on most hardwares)

### Session Type

Secure Session (Wayland, This is the default)

### Software Version

Early Access or Compiled from git

### Log Output

```shell

```

### Hardware Info

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.